milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Fix the `not shard leader` error when gracefully stopping

Open SimFG opened this issue 2 years ago • 15 comments

/kind improvement

SimFG avatar May 11 '23 07:05 SimFG

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar May 11 '23 07:05 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '23 07:05 mergify[bot]

/kind improvement

SimFG avatar May 11 '23 07:05 SimFG

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 11 '23 07:05 mergify[bot]

rerun ut

SimFG avatar May 11 '23 08:05 SimFG

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 11 '23 08:05 mergify[bot]

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 11 '23 08:05 mergify[bot]

rerun ut

SimFG avatar May 11 '23 08:05 SimFG

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 11 '23 09:05 mergify[bot]

Codecov Report

Merging #24038 (3890e3a) into 2.2.0 (5a3e41c) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24038      +/-   ##
==========================================
+ Coverage   80.58%   80.61%   +0.02%     
==========================================
  Files         736      736              
  Lines      103285   103290       +5     
==========================================
+ Hits        83234    83265      +31     
+ Misses      16839    16811      -28     
- Partials     3212     3214       +2     
Impacted Files Coverage Δ
internal/proxy/task_search.go 78.37% <100.00%> (+0.54%) :arrow_up:

... and 18 files with indirect coverage changes

codecov[bot] avatar May 12 '23 06:05 codecov[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 12 '23 09:05 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 12 '23 10:05 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 12 '23 10:05 mergify[bot]

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 12 '23 10:05 mergify[bot]

/lgtm /approve

xiaofan-luan avatar May 15 '23 07:05 xiaofan-luan

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 15 '23 07:05 sre-ci-robot