milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Infer metric type from index

Open chasingegg opened this issue 1 year ago • 10 comments

Related #23849

chasingegg avatar May 08 '23 09:05 chasingegg

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 08 '23 09:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 08 '23 10:05 mergify[bot]

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 08 '23 10:05 mergify[bot]

New changes are detected. LGTM label has been removed.

sre-ci-robot avatar May 29 '23 10:05 sre-ci-robot

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 29 '23 10:05 mergify[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 29 '23 15:05 sre-ci-robot

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 29 '23 16:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 30 '23 05:05 mergify[bot]

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 30 '23 06:05 mergify[bot]

Codecov Report

Merging #23950 (ad45155) into master (99b7a68) will increase coverage by 0.00%. The diff coverage is 71.42%.

:exclamation: Current head ad45155 differs from pull request most recent head 402db4f. Consider uploading reports for the commit 402db4f to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #23950     +/-   ##
=========================================
  Coverage   81.96%   81.97%             
=========================================
  Files         769      777      +8     
  Lines      101449   103057   +1608     
=========================================
+ Hits        83150    84477   +1327     
- Misses      15334    15562    +228     
- Partials     2965     3018     +53     
Impacted Files Coverage Δ
internal/core/src/query/SearchBruteForce.cpp 89.36% <ø> (-0.44%) :arrow_down:
internal/core/src/segcore/IndexConfigGenerator.cpp 0.00% <0.00%> (-100.00%) :arrow_down:
internal/querycoordv2/task/utils.go 92.62% <50.00%> (-2.21%) :arrow_down:
internal/core/src/query/SearchOnGrowing.cpp 63.88% <52.94%> (-36.12%) :arrow_down:
internal/core/src/common/IndexMeta.h 77.77% <100.00%> (-22.23%) :arrow_down:
internal/core/src/query/SearchOnSealed.cpp 100.00% <100.00%> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 72.34% <100.00%> (+1.22%) :arrow_up:
internal/core/src/segcore/SegmentSealedImpl.cpp 77.31% <100.00%> (+0.08%) :arrow_up:
internal/core/src/segcore/SegmentSealedImpl.h 100.00% <100.00%> (ø)
internal/core/src/segcore/segment_c.cpp 68.71% <100.00%> (ø)

... and 122 files with indirect coverage changes

codecov[bot] avatar May 30 '23 06:05 codecov[bot]

#24591 has done the same thing, close this pr.

chasingegg avatar Jun 06 '23 05:06 chasingegg