milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Seal by segment size instead of row number

Open wayblink opened this issue 1 year ago • 9 comments

related: #23587

wayblink avatar May 04 '23 07:05 wayblink

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 04 '23 07:05 sre-ci-robot

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 04 '23 07:05 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 04 '23 07:05 mergify[bot]

rerun ut

wayblink avatar May 05 '23 02:05 wayblink

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 05 '23 02:05 mergify[bot]

rerun ut

wayblink avatar May 05 '23 09:05 wayblink

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 05 '23 09:05 mergify[bot]

Codecov Report

Merging #23854 (d0a895d) into master (38f45c3) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23854      +/-   ##
==========================================
+ Coverage   79.80%   79.81%   +0.01%     
==========================================
  Files         744      744              
  Lines       97577    97582       +5     
==========================================
+ Hits        77867    77882      +15     
+ Misses      16551    16545       -6     
+ Partials     3159     3155       -4     
Impacted Files Coverage Δ
internal/datacoord/segment_allocation_policy.go 82.52% <100.00%> (-6.37%) :arrow_down:
internal/datacoord/segment_manager.go 87.97% <100.00%> (-1.34%) :arrow_down:

... and 14 files with indirect coverage changes

codecov[bot] avatar May 05 '23 12:05 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 08 '23 13:06 stale[bot]