milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[hotfix] Fix shard detector rewatch always returns closed channel (#23734)

Open congqixia opened this issue 1 year ago • 2 comments

Related to #23637 /kind bug

congqixia avatar Apr 28 '23 02:04 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 28 '23 02:04 sre-ci-robot

Codecov Report

Merging #23785 (3de1548) into hotfix-2.2.6 (a078e40) will increase coverage by 0.01%. The diff coverage is 62.50%.

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix-2.2.6   #23785      +/-   ##
================================================
+ Coverage         81.44%   81.45%   +0.01%     
================================================
  Files               709      709              
  Lines            100370   100369       -1     
================================================
+ Hits              81746    81758      +12     
+ Misses            15447    15424      -23     
- Partials           3177     3187      +10     
Impacted Files Coverage Δ
internal/querynode/shard_segment_detector.go 71.85% <57.14%> (+5.38%) :arrow_up:
internal/querynode/shard_node_detector.go 74.88% <100.00%> (+4.27%) :arrow_up:

... and 17 files with indirect coverage changes

codecov[bot] avatar Apr 28 '23 08:04 codecov[bot]