milvus
milvus copied to clipboard
Optimize log when rootcoord goroutine quit (#23698)
/kind improvement
@longjiquan: The label(s) kind/improment
cannot be applied, because the repository doesn't have them.
In response to this:
/kind improment
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@longjiquan Please associate the related issue to the body of your Pull Request. (eg. “issue: #
/kind improvement
@longjiquan ut workflow job failed, comment rerun ut
can trigger the job again.
rerun ut
@longjiquan ut workflow job failed, comment rerun ut
can trigger the job again.
rerun ut
Codecov Report
Merging #23699 (45c76c2) into 2.2.0 (51f5a12) will decrease coverage by
0.29%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## 2.2.0 #23699 +/- ##
==========================================
- Coverage 80.89% 80.61% -0.29%
==========================================
Files 718 713 -5
Lines 101217 101290 +73
==========================================
- Hits 81879 81653 -226
- Misses 16139 16437 +298
- Partials 3199 3200 +1
Impacted Files | Coverage Δ | |
---|---|---|
internal/rootcoord/root_coord.go | 78.00% <100.00%> (+0.02%) |
:arrow_up: |
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: czs007, longjiquan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~internal/rootcoord/OWNERS~~ [czs007]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment