milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Use merr in querycoord

Open smellthemoon opened this issue 1 year ago • 14 comments

Signed-off-by: lixinguo [email protected] /kind improvement

smellthemoon avatar Apr 24 '23 08:04 smellthemoon

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 24 '23 08:04 sre-ci-robot

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '23 08:04 mergify[bot]

Codecov Report

Merging #23659 (17e183e) into master (7be7e6f) will decrease coverage by 0.01%. The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23659      +/-   ##
==========================================
- Coverage   79.81%   79.81%   -0.01%     
==========================================
  Files         754      753       -1     
  Lines       97838    97850      +12     
==========================================
+ Hits        78094    78097       +3     
- Misses      16576    16586      +10     
+ Partials     3168     3167       -1     
Impacted Files Coverage Δ
pkg/util/merr/errors.go 69.56% <ø> (ø)
internal/querycoordv2/job/job_sync.go 69.38% <25.00%> (-1.45%) :arrow_down:
internal/querycoordv2/services.go 84.61% <71.42%> (ø)
internal/querycoordv2/handlers.go 69.75% <100.00%> (-0.18%) :arrow_down:
internal/querycoordv2/job/job_load.go 87.14% <100.00%> (ø)
pkg/util/merr/utils.go 96.15% <100.00%> (+1.53%) :arrow_up:

... and 18 files with indirect coverage changes

codecov[bot] avatar Apr 24 '23 09:04 codecov[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 10:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 12:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 25 '23 07:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '23 07:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 26 '23 06:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 03:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 27 '23 07:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 07:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 27 '23 07:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 07:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 27 '23 09:04 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 04 '23 02:05 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 04 '23 02:05 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar May 04 '23 13:05 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 05 '23 07:05 mergify[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar May 06 '23 03:05 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 22 '23 18:06 stale[bot]