milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Use merr in querynodev2

Open smellthemoon opened this issue 1 year ago • 8 comments

Signed-off-by: lixinguo [email protected] /kind improvement

smellthemoon avatar Apr 24 '23 06:04 smellthemoon

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '23 06:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 06:04 mergify[bot]

Codecov Report

Merging #23652 (eb32e78) into master (60fdd7e) will increase coverage by 0.93%. The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23652      +/-   ##
==========================================
+ Coverage   81.05%   81.99%   +0.93%     
==========================================
  Files         748      744       -4     
  Lines       99340    97257    -2083     
==========================================
- Hits        80524    79745     -779     
+ Misses      15828    14545    -1283     
+ Partials     2988     2967      -21     
Impacted Files Coverage Δ
internal/querynodev2/pipeline/filter_node.go 81.31% <0.00%> (ø)
internal/querynodev2/pipeline/manager.go 69.87% <0.00%> (-0.86%) :arrow_down:
internal/querynodev2/pipeline/message.go 84.61% <0.00%> (ø)
pkg/util/merr/errors.go 69.56% <ø> (ø)
internal/querynodev2/handlers.go 73.25% <50.00%> (-0.23%) :arrow_down:
internal/querynodev2/collector/average.go 100.00% <100.00%> (ø)
internal/querynodev2/pipeline/filter_policy.go 100.00% <100.00%> (ø)
internal/querynodev2/services.go 85.17% <100.00%> (-0.10%) :arrow_down:
pkg/util/merr/utils.go 96.92% <100.00%> (+1.46%) :arrow_up:

... and 188 files with indirect coverage changes

codecov[bot] avatar Apr 24 '23 07:04 codecov[bot]

@smellthemoon ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 24 '23 11:04 mergify[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 12:04 mergify[bot]

/run-cpu-e2e

smellthemoon avatar Apr 25 '23 07:04 smellthemoon

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 25 '23 07:04 mergify[bot]

/lgtm /approve

jiaoew1991 avatar Apr 26 '23 09:04 jiaoew1991

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 26 '23 09:04 sre-ci-robot