milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Implement GetIndexStatistics interface

Open wayblink opened this issue 1 year ago • 11 comments

related: #22888

proto: https://github.com/milvus-io/milvus-proto/pull/131

wayblink avatar Apr 21 '23 09:04 wayblink

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Apr 21 '23 09:04 mergify[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 21 '23 09:04 mergify[bot]

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 21 '23 10:04 mergify[bot]

Codecov Report

Merging #23603 (a8bae61) into master (6b29a99) will increase coverage by 0.03%. The diff coverage is 80.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23603      +/-   ##
==========================================
+ Coverage   82.04%   82.07%   +0.03%     
==========================================
  Files         742      742              
  Lines       96920    97142     +222     
==========================================
+ Hits        79518    79731     +213     
- Misses      14441    14451      +10     
+ Partials     2961     2960       -1     
Impacted Files Coverage Δ
internal/proxy/task_index.go 71.96% <62.33%> (-1.62%) :arrow_down:
internal/distributed/datacoord/client/client.go 74.40% <70.00%> (+0.61%) :arrow_up:
internal/proxy/impl.go 81.17% <81.94%> (-0.02%) :arrow_down:
internal/datacoord/index_service.go 94.96% <98.57%> (+0.64%) :arrow_up:
internal/distributed/datacoord/service.go 92.23% <100.00%> (+0.07%) :arrow_up:
internal/util/mock/grpc_datacoord_client.go 91.01% <100.00%> (+0.20%) :arrow_up:

... and 8 files with indirect coverage changes

codecov[bot] avatar Apr 21 '23 10:04 codecov[bot]

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 21 '23 10:04 mergify[bot]

/lgtm

soothing-rain avatar Apr 21 '23 10:04 soothing-rain

/lgtm

soothing-rain avatar Apr 22 '23 10:04 soothing-rain

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 24 '23 03:04 mergify[bot]

rerun ut

wayblink avatar Apr 24 '23 11:04 wayblink

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 06 '23 02:05 sre-ci-robot