milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Support to parse ANNS plan node

Open longjiquan opened this issue 1 year ago • 2 comments

/kind improvement

longjiquan avatar Apr 17 '23 08:04 longjiquan

Codecov Report

Merging #23463 (ce8f117) into sql_beta (43ac451) will increase coverage by 0.00%. The diff coverage is 69.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           sql_beta   #23463    +/-   ##
==========================================
  Coverage     79.32%   79.32%            
==========================================
  Files           794      799     +5     
  Lines         98490    98715   +225     
==========================================
+ Hits          78127    78307   +180     
- Misses        17237    17277    +40     
- Partials       3126     3131     +5     
Impacted Files Coverage Δ
...mysqld/planner/visitor_expression_text_restorer.go 44.08% <0.00%> (ø)
internal/mysqld/planner/visitor_json.go 97.18% <11.11%> (-2.82%) :arrow_down:
internal/mysqld/parser/antlrparser/node_ret.go 44.62% <50.00%> (+0.93%) :arrow_up:
internal/mysqld/sqlutil/conv.go 50.00% <50.00%> (ø)
internal/mysqld/parser/antlrparser/ast_builder.go 44.28% <64.17%> (+5.99%) :arrow_up:
internal/mysqld/planner/anns_clause.go 92.59% <92.59%> (ø)
internal/mysqld/planner/float_vector.go 100.00% <100.00%> (ø)
internal/mysqld/planner/kv_pair.go 100.00% <100.00%> (ø)
internal/mysqld/planner/query_specification.go 93.61% <100.00%> (+1.30%) :arrow_up:
internal/mysqld/planner/vector.go 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

codecov[bot] avatar Apr 17 '23 09:04 codecov[bot]

/approve /lgtm

czs007 avatar Apr 18 '23 01:04 czs007

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 18 '23 01:04 sre-ci-robot