milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[2.2.0]Fix graceful stop may not wait for the query goroutines done

Open smellthemoon opened this issue 1 year ago • 6 comments

Signed-off-by: lixinguo [email protected] /kind improvement

smellthemoon avatar Mar 29 '23 03:03 smellthemoon

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Mar 29 '23 03:03 sre-ci-robot

Does search has the same problem?

yah01 avatar Mar 29 '23 03:03 yah01

Does search has the same problem?

Yes, have already modified it.

smellthemoon avatar Mar 29 '23 03:03 smellthemoon

rerun ut

smellthemoon avatar Mar 29 '23 05:03 smellthemoon

Codecov Report

Merging #23093 (19774de) into 2.2.0 (7465804) will increase coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23093      +/-   ##
==========================================
+ Coverage   80.95%   80.97%   +0.01%     
==========================================
  Files         717      717              
  Lines      100533   100531       -2     
==========================================
+ Hits        81389    81407      +18     
+ Misses      15973    15960      -13     
+ Partials     3171     3164       -7     
Impacted Files Coverage Δ
internal/querynode/impl.go 66.26% <0.00%> (-0.40%) :arrow_down:

... and 15 files with indirect coverage changes

codecov[bot] avatar Mar 29 '23 07:03 codecov[bot]

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 23 '23 13:04 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar May 23 '23 14:05 stale[bot]