milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Refactor cmake files

Open jiaoew1991 opened this issue 1 year ago • 40 comments

/kind improvement

jiaoew1991 avatar Mar 27 '23 06:03 jiaoew1991

@jiaoew1991 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar Mar 27 '23 06:03 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '23 06:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 27 '23 06:03 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '23 06:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 27 '23 08:03 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '23 08:03 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 27 '23 11:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 27 '23 13:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 28 '23 02:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 29 '23 06:03 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Mar 29 '23 06:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Mar 29 '23 08:03 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 04 '23 07:04 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 04 '23 09:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 04 '23 11:04 mergify[bot]

@jiaoew1991, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

mergify[bot] avatar Apr 05 '23 00:04 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 05 '23 00:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 05 '23 01:04 mergify[bot]

Codecov Report

Merging #23006 (307e110) into master (30415e1) will decrease coverage by 0.51%. The diff coverage is 69.23%.

:exclamation: Current head 307e110 differs from pull request most recent head 0d09d23. Consider uploading reports for the commit 0d09d23 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23006      +/-   ##
==========================================
- Coverage   82.05%   81.54%   -0.51%     
==========================================
  Files         754      791      +37     
  Lines       99026   105479    +6453     
==========================================
+ Hits        81258    86017    +4759     
- Misses      14739    16145    +1406     
- Partials     3029     3317     +288     
Impacted Files Coverage Δ
internal/core/src/common/BitsetView.h 87.50% <ø> (ø)
internal/core/src/common/dynamic_bitset_ext.cpp 50.00% <ø> (ø)
internal/core/src/index/IndexFactory.cpp 59.09% <ø> (ø)
internal/core/src/index/IndexFactory.h 100.00% <ø> (ø)
internal/core/src/index/VectorDiskIndex.cpp 0.00% <ø> (ø)
internal/core/src/index/VectorDiskIndex.h 0.00% <ø> (ø)
internal/core/src/indexbuilder/VecIndexCreator.cpp 80.48% <ø> (ø)
internal/core/src/indexbuilder/init_c.cpp 0.00% <0.00%> (ø)
internal/core/src/segcore/load_index_c.cpp 54.73% <ø> (ø)
internal/core/src/storage/Util.cpp 82.30% <ø> (+5.87%) :arrow_up:
... and 16 more

... and 606 files with indirect coverage changes

codecov[bot] avatar Apr 05 '23 05:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Apr 06 '23 09:04 sre-ci-robot

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 06 '23 10:04 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 07 '23 23:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 08 '23 00:04 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 08 '23 00:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 08 '23 00:04 mergify[bot]

@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Apr 08 '23 00:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 08 '23 00:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 08 '23 05:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 08 '23 05:04 mergify[bot]

@jiaoew1991 ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Apr 26 '23 11:04 mergify[bot]