milvus
milvus copied to clipboard
Refactor cmake files
/kind improvement
@jiaoew1991 Please associate the related issue to the body of your Pull Request. (eg. “issue: #
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
Codecov Report
Merging #23006 (307e110) into master (30415e1) will decrease coverage by
0.51%
. The diff coverage is69.23%
.
:exclamation: Current head 307e110 differs from pull request most recent head 0d09d23. Consider uploading reports for the commit 0d09d23 to get more accurate results
@@ Coverage Diff @@
## master #23006 +/- ##
==========================================
- Coverage 82.05% 81.54% -0.51%
==========================================
Files 754 791 +37
Lines 99026 105479 +6453
==========================================
+ Hits 81258 86017 +4759
- Misses 14739 16145 +1406
- Partials 3029 3317 +288
Impacted Files | Coverage Δ | |
---|---|---|
internal/core/src/common/BitsetView.h | 87.50% <ø> (ø) |
|
internal/core/src/common/dynamic_bitset_ext.cpp | 50.00% <ø> (ø) |
|
internal/core/src/index/IndexFactory.cpp | 59.09% <ø> (ø) |
|
internal/core/src/index/IndexFactory.h | 100.00% <ø> (ø) |
|
internal/core/src/index/VectorDiskIndex.cpp | 0.00% <ø> (ø) |
|
internal/core/src/index/VectorDiskIndex.h | 0.00% <ø> (ø) |
|
internal/core/src/indexbuilder/VecIndexCreator.cpp | 80.48% <ø> (ø) |
|
internal/core/src/indexbuilder/init_c.cpp | 0.00% <0.00%> (ø) |
|
internal/core/src/segcore/load_index_c.cpp | 54.73% <ø> (ø) |
|
internal/core/src/storage/Util.cpp | 82.30% <ø> (+5.87%) |
:arrow_up: |
... and 16 more |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jiaoew1991
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [jiaoew1991]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.
@jiaoew1991 ut workflow job failed, comment rerun ut
can trigger the job again.