milvus
milvus copied to clipboard
[Enhancement]: Add `ServiceDiscovery` abstraction
Is there an existing issue for this?
- [X] I have searched the existing issues
What would you like to be added?
Add ServiceDiscovery
abstraction and refactor sessionutil
package
Why is this needed?
With ServiceDiscovery
abstraction, it's easier to integrate other registry service such as Consul, ZK, etc.
And currently the Session
provides too much function which does not make sense, say "list other session"
Also, with ServiceDiscovery
interface, we could implement internal process call in Standlone
, Mixcoord
or any other mixture deployment mode instead of heavy grpc call.
Anything else?
No response
- [ ] Add
ServiceDiscovery
interface definition - [ ] Provides all features
sessionutil
has - [ ] Add
InternalProcessServiceDiscovery
implementation - [ ] Adapt
ServiceDiscovery
as dependency in all components- [ ] Datacoord
- [ ] Querycoord
- [ ] RootCoord
- [ ] DataNode
- [ ] QueryNode
- [ ] IndexNode
- [ ] proxy
- [ ] Remove
sessionutil
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
keep it
/reopen
@congqixia: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
/reopen
@jiaoew1991: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
keep it open
/reopen
@jiaoew1991: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
/reopen still WIP
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.
/reopen
@jiaoew1991: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.