milvus icon indicating copy to clipboard operation
milvus copied to clipboard

[Enhancement]: Add `ServiceDiscovery` abstraction

Open congqixia opened this issue 1 year ago • 6 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What would you like to be added?

Add ServiceDiscovery abstraction and refactor sessionutil package

Why is this needed?

With ServiceDiscovery abstraction, it's easier to integrate other registry service such as Consul, ZK, etc. And currently the Session provides too much function which does not make sense, say "list other session" Also, with ServiceDiscovery interface, we could implement internal process call in Standlone, Mixcoord or any other mixture deployment mode instead of heavy grpc call.

Anything else?

No response

congqixia avatar Mar 24 '23 03:03 congqixia

  • [ ] Add ServiceDiscovery interface definition
  • [ ] Provides all features sessionutil has
  • [ ] Add InternalProcessServiceDiscovery implementation
  • [ ] Adapt ServiceDiscovery as dependency in all components
    • [ ] Datacoord
    • [ ] Querycoord
    • [ ] RootCoord
    • [ ] DataNode
    • [ ] QueryNode
    • [ ] IndexNode
    • [ ] proxy
  • [ ] Remove sessionutil

congqixia avatar Mar 24 '23 03:03 congqixia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Apr 23 '23 06:04 stale[bot]

keep it

xiaofan-luan avatar Apr 23 '23 19:04 xiaofan-luan

/reopen

congqixia avatar May 05 '23 10:05 congqixia

@congqixia: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar May 05 '23 10:05 sre-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jun 08 '23 17:06 stale[bot]

/reopen

jiaoew1991 avatar Jun 16 '23 02:06 jiaoew1991

@jiaoew1991: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Jun 16 '23 02:06 sre-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Jul 16 '23 03:07 stale[bot]

keep it open

xiaofan-luan avatar Jul 23 '23 03:07 xiaofan-luan

/reopen

jiaoew1991 avatar Jul 24 '23 02:07 jiaoew1991

@jiaoew1991: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Jul 24 '23 02:07 sre-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Aug 23 '23 20:08 stale[bot]

/reopen still WIP

congqixia avatar Aug 24 '23 00:08 congqixia

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Sep 23 '23 03:09 stale[bot]

/reopen

jiaoew1991 avatar Oct 12 '23 23:10 jiaoew1991

@jiaoew1991: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Oct 12 '23 23:10 sre-ci-robot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Nov 11 '23 23:11 stale[bot]