milvus
milvus copied to clipboard
support velox engine for segcore(#22920)
#22920
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: zhagnlu
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e
can trigger the job again.
@zhagnlu ut workflow job failed, comment rerun ut
can trigger the job again.
Codecov Report
Merging #22929 (3d12454) into sql_beta (ce2c5d1) will decrease coverage by
0.70%
. The diff coverage is4.68%
.
@@ Coverage Diff @@
## sql_beta #22929 +/- ##
============================================
- Coverage 81.86% 81.16% -0.70%
============================================
Files 776 784 +8
Lines 100230 102743 +2513
============================================
+ Hits 82051 83394 +1343
- Misses 15065 16233 +1168
- Partials 3114 3116 +2
Impacted Files | Coverage Δ | |
---|---|---|
internal/core/src/query/Expr.h | 57.77% <0.00%> (-42.23%) |
:arrow_down: |
internal/core/src/query/PlanNode.h | 100.00% <ø> (ø) |
|
...al/core/src/query/visitors/ExecPlanNodeVisitor.cpp | 97.72% <ø> (-2.28%) |
:arrow_down: |
internal/core/src/segcore/ConcurrentVector.h | 81.74% <0.00%> (-2.47%) |
:arrow_down: |
internal/core/src/segcore/FieldIndexing.cpp | 92.85% <ø> (-1.27%) |
:arrow_down: |
internal/core/src/segcore/FieldIndexing.h | 98.14% <ø> (+0.52%) |
:arrow_up: |
internal/core/src/segcore/Reduce.cpp | 93.05% <ø> (-1.04%) |
:arrow_down: |
internal/core/src/segcore/SegmentGrowingImpl.h | 86.66% <ø> (+3.33%) |
:arrow_up: |
internal/core/src/segcore/SegmentSealedImpl.cpp | 76.80% <ø> (-4.30%) |
:arrow_down: |
internal/core/src/segcore/SegmentSealedImpl.h | 85.00% <0.00%> (-15.00%) |
:arrow_down: |
... and 11 more |
@zhagnlu, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen
.