milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add funlen linter

Open congqixia opened this issue 2 years ago • 3 comments

/kind improvement

Signed-off-by: Congqi Xia [email protected]

congqixia avatar Sep 21 '22 09:09 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 21 '22 09:09 sre-ci-robot

/lgtm

jiaoew1991 avatar Sep 21 '22 09:09 jiaoew1991

/assign

yah01 avatar Sep 21 '22 13:09 yah01

New changes are detected. LGTM label has been removed.

sre-ci-robot avatar Sep 23 '22 02:09 sre-ci-robot

@congqixia, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

mergify[bot] avatar Sep 23 '22 07:09 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 23 '22 07:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 23 '22 07:09 mergify[bot]

Codecov Report

Merging #19336 (3c3de5e) into master (c58a8d8) will decrease coverage by 0.23%. The diff coverage is 51.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19336      +/-   ##
==========================================
- Coverage   81.01%   80.78%   -0.24%     
==========================================
  Files         668      668              
  Lines       94571    94589      +18     
==========================================
- Hits        76619    76416     -203     
- Misses      14696    14916     +220     
- Partials     3256     3257       +1     
Impacted Files Coverage Δ
internal/storage/data_codec.go 68.92% <40.90%> (+0.12%) :arrow_up:
internal/storage/print_binlog.go 61.26% <57.63%> (-0.17%) :arrow_down:
internal/querycoordv2/meta/coordinator_broker.go 34.42% <0.00%> (-32.79%) :arrow_down:
internal/querycoordv2/utils/types.go 78.12% <0.00%> (-21.88%) :arrow_down:
internal/indexnode/chunk_mgr_factory.go 60.00% <0.00%> (-20.00%) :arrow_down:
internal/querynode/impl_utils.go 0.00% <0.00%> (-17.40%) :arrow_down:
internal/querycoordv2/task/utils.go 71.89% <0.00%> (-16.34%) :arrow_down:
internal/querynode/task_statistics.go 47.11% <0.00%> (-11.54%) :arrow_down:
internal/querycoordv2/dist/dist_handler.go 76.05% <0.00%> (-9.16%) :arrow_down:
internal/querynode/shard_cluster.go 90.26% <0.00%> (-4.14%) :arrow_down:
... and 23 more

codecov[bot] avatar Sep 23 '22 08:09 codecov[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 28 '22 02:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 28 '22 03:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Oct 12 '22 08:10 mergify[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

stale[bot] avatar Nov 11 '22 09:11 stale[bot]