milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add Revert in DataCoord meta catalog

Open XuanYang-cn opened this issue 2 years ago • 6 comments

See also: #19072

Signed-off-by: yangxuan [email protected]

XuanYang-cn avatar Sep 21 '22 02:09 XuanYang-cn

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 03:09 mergify[bot]

/run-cpu-e2e

XuanYang-cn avatar Sep 21 '22 03:09 XuanYang-cn

Codecov Report

Merging #19313 (3bf649f) into master (1cd6e80) will decrease coverage by 0.05%. The diff coverage is 29.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19313      +/-   ##
==========================================
- Coverage   80.25%   80.20%   -0.06%     
==========================================
  Files         673      673              
  Lines       94169    94324     +155     
==========================================
+ Hits        75578    75654      +76     
- Misses      15324    15393      +69     
- Partials     3267     3277      +10     
Impacted Files Coverage Δ
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/kv/mocks/TxnKV.go 16.10% <18.03%> (+16.10%) :arrow_up:
internal/metastore/kv/datacoord/kv_catalog.go 79.22% <72.72%> (-0.86%) :arrow_down:
internal/distributed/indexcoord/client/client.go 51.23% <0.00%> (-4.33%) :arrow_down:
internal/util/grpcclient/client.go 94.37% <0.00%> (-1.88%) :arrow_down:
internal/querycoordv2/checkers/channel_checker.go 93.10% <0.00%> (-1.15%) :arrow_down:
internal/querycoordv2/task/scheduler.go 74.58% <0.00%> (-0.48%) :arrow_down:
internal/indexcoord/meta_table.go 95.50% <0.00%> (+0.25%) :arrow_up:
internal/querycoord/query_coord.go 77.38% <0.00%> (+0.56%) :arrow_up:
internal/mq/msgstream/mq_msgstream.go 79.17% <0.00%> (+0.56%) :arrow_up:
... and 5 more

codecov[bot] avatar Sep 21 '22 03:09 codecov[bot]

/assgin @congqixia @aakejiang Please help reivew this code

XuanYang-cn avatar Sep 21 '22 06:09 XuanYang-cn

#19289

XuanYang-cn avatar Sep 22 '22 07:09 XuanYang-cn

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 23 '22 02:09 sre-ci-robot