milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Add SyncSegments into proto

Open XuanYang-cn opened this issue 2 years ago • 7 comments

See also: #19072

Signed-off-by: yangxuan [email protected]

XuanYang-cn avatar Sep 21 '22 02:09 XuanYang-cn

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 03:09 mergify[bot]

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 03:09 mergify[bot]

rerun ut

XuanYang-cn avatar Sep 21 '22 06:09 XuanYang-cn

Codecov Report

Merging #19312 (b728139) into master (72ee35a) will decrease coverage by 0.00%. The diff coverage is 79.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19312      +/-   ##
==========================================
- Coverage   80.25%   80.25%   -0.01%     
==========================================
  Files         673      673              
  Lines       94174    94285     +111     
==========================================
+ Hits        75581    75669      +88     
- Misses      15326    15349      +23     
  Partials     3267     3267              
Impacted Files Coverage Δ
internal/distributed/datanode/client/client.go 72.61% <0.00%> (-4.94%) :arrow_down:
internal/distributed/datanode/service.go 77.29% <0.00%> (-0.69%) :arrow_down:
internal/util/mock/grpc_datanode_client.go 91.66% <0.00%> (-8.34%) :arrow_down:
internal/datanode/data_node.go 82.27% <75.00%> (-0.39%) :arrow_down:
internal/datanode/flow_graph_delete_node.go 93.05% <100.00%> (+0.33%) :arrow_up:
internal/datanode/flow_graph_manager.go 93.04% <100.00%> (+1.04%) :arrow_up:
internal/datanode/segment_replica.go 89.44% <100.00%> (+1.60%) :arrow_up:
internal/distributed/indexcoord/client/client.go 51.23% <0.00%> (-4.33%) :arrow_down:
internal/datacoord/util.go 84.92% <0.00%> (-1.59%) :arrow_down:
internal/datacoord/handler.go 78.98% <0.00%> (-1.45%) :arrow_down:
... and 21 more

codecov[bot] avatar Sep 21 '22 07:09 codecov[bot]

/assign @congqixia @jiaoew1991 Please help to review this PR

XuanYang-cn avatar Sep 21 '22 07:09 XuanYang-cn

/lgtm

jiaoew1991 avatar Sep 22 '22 07:09 jiaoew1991

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 23 '22 02:09 sre-ci-robot