milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Return task context error when read task timeout

Open congqixia opened this issue 2 years ago • 13 comments

Return ctx error when task read timeout so that shard cluster could display correct error message

/kind improvement

Signed-off-by: Congqi Xia [email protected]

congqixia avatar Sep 20 '22 06:09 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 20 '22 06:09 sre-ci-robot

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 20 '22 07:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 20 '22 07:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 20 '22 08:09 mergify[bot]

Codecov Report

Merging #19288 (7602d49) into master (b30c9d4) will increase coverage by 0.00%. The diff coverage is 55.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19288   +/-   ##
=======================================
  Coverage   81.02%   81.03%           
=======================================
  Files         667      667           
  Lines       94263    94288   +25     
=======================================
+ Hits        76380    76403   +23     
- Misses      14638    14640    +2     
  Partials     3245     3245           
Impacted Files Coverage Δ
internal/indexnode/task.go 53.29% <0.00%> (-0.93%) :arrow_down:
internal/rootcoord/meta_table.go 68.69% <ø> (-2.54%) :arrow_down:
internal/util/indexcgowrapper/index.go 70.14% <0.00%> (ø)
internal/querynode/task_read.go 64.93% <66.66%> (+8.93%) :arrow_up:
internal/rootcoord/import_helper.go 60.00% <66.66%> (ø)
internal/proxy/task.go 84.30% <100.00%> (ø)
internal/querynode/shard_cluster.go 93.32% <100.00%> (-0.03%) :arrow_down:
internal/querynode/task_scheduler.go 68.63% <100.00%> (+6.13%) :arrow_up:
internal/rootcoord/root_coord.go 77.19% <100.00%> (-0.33%) :arrow_down:
internal/indexnode/taskinfo_ops.go 82.08% <0.00%> (-13.44%) :arrow_down:
... and 31 more

codecov[bot] avatar Sep 20 '22 08:09 codecov[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 20 '22 09:09 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 21 '22 09:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 10:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 11:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 21 '22 14:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 22 '22 03:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 22 '22 03:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 22 '22 10:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 27 '22 03:09 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 27 '22 03:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 27 '22 06:09 mergify[bot]

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 27 '22 09:09 mergify[bot]

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] avatar Sep 27 '22 09:09 mergify[bot]

/lgtm

yah01 avatar Sep 28 '22 02:09 yah01