milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Change compactor policy from loading all binlogs to loading serially …

Open zhagnlu opened this issue 2 years ago • 4 comments

#19073 Signed-off-by: zhagnlu [email protected]

zhagnlu avatar Sep 19 '22 12:09 zhagnlu

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 19 '22 12:09 mergify[bot]

Codecov Report

Merging #19280 (1de8c1a) into master (ee9d634) will increase coverage by 0.21%. The diff coverage is 81.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19280      +/-   ##
==========================================
+ Coverage   80.28%   80.50%   +0.21%     
==========================================
  Files         673      675       +2     
  Lines       94185    94730     +545     
==========================================
+ Hits        75618    76261     +643     
+ Misses      15302    15229      -73     
+ Partials     3265     3240      -25     
Impacted Files Coverage Δ
internal/datanode/compactor.go 84.27% <74.82%> (-1.12%) :arrow_down:
internal/datacoord/segment_allocation_policy.go 94.62% <76.92%> (-2.88%) :arrow_down:
internal/datanode/binlog_io.go 93.66% <87.30%> (-1.60%) :arrow_down:
internal/datacoord/compaction_trigger.go 80.47% <87.50%> (+0.58%) :arrow_up:
internal/util/paramtable/component_param.go 87.53% <100.00%> (+0.13%) :arrow_up:
internal/util/mock/grpc_datanode_client.go 91.66% <0.00%> (-8.34%) :arrow_down:
internal/distributed/datanode/client/client.go 72.61% <0.00%> (-4.94%) :arrow_down:
internal/querynode/query_shard_service.go 95.34% <0.00%> (-4.66%) :arrow_down:
internal/distributed/connection_manager.go 70.03% <0.00%> (-3.98%) :arrow_down:
internal/querycoord/channel_unsubscribe.go 80.17% <0.00%> (-2.59%) :arrow_down:
... and 61 more

codecov[bot] avatar Sep 19 '22 13:09 codecov[bot]

@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] avatar Sep 20 '22 08:09 mergify[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Sep 23 '22 06:09 sre-ci-robot

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 23 '22 08:09 mergify[bot]

/lgtm

xige-16 avatar Sep 23 '22 08:09 xige-16

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 23 '22 09:09 mergify[bot]

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] avatar Sep 24 '22 02:09 mergify[bot]

/lgtm

xige-16 avatar Sep 24 '22 10:09 xige-16