milvus icon indicating copy to clipboard operation
milvus copied to clipboard

Disable ut about kafka temporarily

Open jaime0815 opened this issue 2 years ago • 3 comments

The Kafka mock server has a lost data issue occasionally that will lead to ut failure, so decide to disable it temporarily /kind improvement Signed-off-by: yun.zhang [email protected]

jaime0815 avatar Aug 11 '22 09:08 jaime0815

Codecov Report

Merging #18611 (465e5bd) into master (097f144) will increase coverage by 0.01%. The diff coverage is 87.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18611      +/-   ##
==========================================
+ Coverage   82.27%   82.29%   +0.01%     
==========================================
  Files         497      529      +32     
  Lines       78799    80671    +1872     
==========================================
+ Hits        64831    66385    +1554     
- Misses      11127    11319     +192     
- Partials     2841     2967     +126     
Impacted Files Coverage Δ
internal/metastore/model/alias.go 50.00% <50.00%> (ø)
internal/metastore/kv/kv_catalog.go 87.21% <86.75%> (+4.29%) :arrow_up:
internal/rootcoord/meta_table.go 89.51% <92.30%> (+0.30%) :arrow_up:
internal/kv/mock_snapshot_kv.go 100.00% <100.00%> (ø)
internal/metastore/model/collection.go 100.00% <100.00%> (ø)
internal/metastore/model/partition.go 100.00% <100.00%> (ø)
internal/util/paramtable/service_param.go 69.10% <0.00%> (-14.57%) :arrow_down:
internal/proxy/channels_time_ticker.go 78.35% <0.00%> (-4.48%) :arrow_down:
internal/util/grpcclient/client.go 92.50% <0.00%> (-1.88%) :arrow_down:
internal/mq/mqimpl/rocksmq/client/client_impl.go 77.96% <0.00%> (-1.70%) :arrow_down:
... and 62 more

codecov[bot] avatar Aug 11 '22 09:08 codecov[bot]

/lgtm

jiaoew1991 avatar Aug 11 '22 10:08 jiaoew1991

/approve

congqixia avatar Aug 12 '22 05:08 congqixia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Aug 12 '22 05:08 sre-ci-robot