milvus-sdk-cpp
milvus-sdk-cpp copied to clipboard
Added GPU IndexTypes to support Milvus-GPU
Added the GPU index types as metioned in Issue #257
Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉
Codecov Report
Attention: 4 lines
in your changes are missing coverage. Please review.
Comparison is base (
e90aa2f
) 97.33% compared to head (30ff077
) 97.19%.
Additional details and impacted files
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 97.33% 97.19% -0.15%
==========================================
Files 34 34
Lines 2628 2637 +9
==========================================
+ Hits 2558 2563 +5
- Misses 70 74 +4
Files | Coverage Δ | |
---|---|---|
src/impl/types/IndexDesc.cpp | 98.88% <100.00%> (+0.01%) |
:arrow_up: |
src/impl/TypeUtils.cpp | 97.80% <50.00%> (-0.61%) |
:arrow_down: |
/lgtm
/label ci-pass
@matrixji: The label(s) /label ci-pass
cannot be applied. These labels are supported: sdk/c++, sdk/go, sdk/http, sdk/java, sdk/python, severity/critical, severity/major, severity/minor, severity/moderate, test/accuracy, test/stability, test/ut, Summer 2021, WHY NOT
In response to this:
/label ci-pass
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@luisfmnunes could you try to fix the clang-format issue with make clang-format
in the build directory? I could not directly merge your PR until you fix the format issue.
New changes are detected. LGTM label has been removed.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: luisfmnunes To complete the pull request process, please ask for approval from matrixji after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@luisfmnunes could you try to fix the clang-format issue with
make clang-format
in the build directory? I could not directly merge your PR until you fix the format issue.
Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format
/lgtm
@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target.