milvus-sdk-cpp icon indicating copy to clipboard operation
milvus-sdk-cpp copied to clipboard

Added GPU IndexTypes to support Milvus-GPU

Open luisfmnunes opened this issue 1 year ago • 11 comments

Added the GPU index types as metioned in Issue #257

luisfmnunes avatar Feb 02 '24 19:02 luisfmnunes

Welcome @luisfmnunes! It looks like this is your first PR to milvus-io/milvus-sdk-cpp 🎉

sre-ci-robot avatar Feb 02 '24 19:02 sre-ci-robot

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e90aa2f) 97.33% compared to head (30ff077) 97.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   97.33%   97.19%   -0.15%     
==========================================
  Files          34       34              
  Lines        2628     2637       +9     
==========================================
+ Hits         2558     2563       +5     
- Misses         70       74       +4     
Files Coverage Δ
src/impl/types/IndexDesc.cpp 98.88% <100.00%> (+0.01%) :arrow_up:
src/impl/TypeUtils.cpp 97.80% <50.00%> (-0.61%) :arrow_down:

codecov[bot] avatar Feb 02 '24 23:02 codecov[bot]

/lgtm

matrixji avatar Feb 09 '24 13:02 matrixji

/label ci-pass

matrixji avatar Feb 09 '24 13:02 matrixji

@matrixji: The label(s) /label ci-pass cannot be applied. These labels are supported: sdk/c++, sdk/go, sdk/http, sdk/java, sdk/python, severity/critical, severity/major, severity/minor, severity/moderate, test/accuracy, test/stability, test/ut, Summer 2021, WHY NOT

In response to this:

/label ci-pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sre-ci-robot avatar Feb 09 '24 13:02 sre-ci-robot

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

matrixji avatar Feb 17 '24 11:02 matrixji

New changes are detected. LGTM label has been removed.

sre-ci-robot avatar Feb 20 '24 11:02 sre-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luisfmnunes To complete the pull request process, please ask for approval from matrixji after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Feb 20 '24 11:02 sre-ci-robot

@luisfmnunes could you try to fix the clang-format issue with make clang-format in the build directory? I could not directly merge your PR until you fix the format issue.

Sorry about that, seems like I messed up the identation somewhere and it was crashing clang build. I pushed a commit after running clang-format

luisfmnunes avatar Feb 20 '24 11:02 luisfmnunes

/lgtm

matrixji avatar Feb 22 '24 10:02 matrixji

@luisfmnunes sorry for handling this late, could you rebase your branch, then the codecov may pass, as I just update the codecov patch coverage target.

matrixji avatar Feb 29 '24 14:02 matrixji