knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

Fix Distance.cu bitset idx match

Open kayang-potato opened this issue 2 years ago • 6 comments

When running a batch, the bitset match is incorrect.

kayang-potato avatar May 21 '23 16:05 kayang-potato

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kayang-potato To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar May 21 '23 16:05 sre-ci-robot

@kayang-potato Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify[bot] avatar May 21 '23 16:05 mergify[bot]

Hi @kayang-potato , By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere. How did you find this issue ?

cydrain avatar May 22 '23 10:05 cydrain

/hold

cydrain avatar May 23 '23 02:05 cydrain

Hi @kayang-potato , By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere. How did you find this issue ?

image

您好,这张CMakelists中表明除了RAFT GPU index,knowhere还编译了Flat GPU,而该索引search的底层调用了thirdparty/faiss/faiss/gpu/impl/Distance.curunDistance函数,该函数错误地使用了bitset,麻烦再关注一下,感谢!

kayang-potato avatar May 23 '23 14:05 kayang-potato

Hi @kayang-potato , By now knowhere only supports RAFT GPU index, Faiss GPU index has not been compiled in knowhere. How did you find this issue ?

image

您好,这张CMakelists中表明除了RAFT GPU index,knowhere还编译了Flat GPU,而该索引search的底层调用了thirdparty/faiss/faiss/gpu/impl/Distance.curunDistance函数,该函数错误地使用了bitset,麻烦再关注一下,感谢!

The line 108 means, removing ${KNOWHERE_GPU_SRCS} from ${KNOWHERE_SRCS}

cydrain avatar May 26 '23 07:05 cydrain