angular-google-signin icon indicating copy to clipboard operation
angular-google-signin copied to clipboard

ERROR in GoogleSignInComponent is not an NgModule

Open KoldBrewEd opened this issue 7 years ago • 9 comments

Is this still maintained?

Broken with Angular 4. You need to update the dependencies:

npm WARN [email protected] requires a peer of @angular/core@^2.0.0 but none was installed. npm WARN [email protected] requires a peer of [email protected] but none was installed. npm WARN [email protected] requires a peer of zone.js@^0.6.25 but none was installed.

KoldBrewEd avatar Apr 19 '17 14:04 KoldBrewEd

Hi! I will put an eye on it in a few days. You are welcome to send me a PR in the meantime.

miltador avatar Apr 24 '17 19:04 miltador

+1 :-) Can't really help, I'm a newbie :-(

andrei-ivanov avatar May 10 '17 19:05 andrei-ivanov

any update on a potential fix?

m47een avatar Jun 21 '17 17:06 m47een

any updates on this?

shah-smit avatar Aug 01 '17 14:08 shah-smit

I am not sure whether I have that peer dependencies error or not(but I guess I have it too), but the point is you need to declare it yourself then it will work. I am using Angular 4.3.3 and don't have any problem

tom10271 avatar Oct 13 '17 02:10 tom10271

Hi! I will look into it this weekend, bare with me!

miltador avatar Dec 22 '17 09:12 miltador

any update?

MaciejWWojcik avatar May 03 '18 20:05 MaciejWWojcik

AOT build is still broken as well, any news/plans on that matter :) ?

PierreRoudaut avatar May 04 '18 08:05 PierreRoudaut

Maybe someone else with enough experience can fix this and send a PR? :-) And even check if it works on Angular 6? :-D

andrei-ivanov avatar May 04 '18 08:05 andrei-ivanov