Milton Reder
Milton Reder
@cgrand thanks, I love where this project is going! One last review note , I added two additional commits to produce slightly more useable errors (that have the spec keyword,...
@Argenrost @vbhayden You might want to look at the testing for `XAPI-00321` (works in a grep), it looks like it still expects the old `1.0.x` version for everything aside from...
Some tests also now seem to expect an `X-Experience-Api-Version` header on `400` responses (not sure they did before), couldn't find discussion of that in the changelogs.
The changes look good for setting the headers! I'm now running into an issue when I try to make an LRS that is backwards compatible with 1.0.x: It looks like...
> Better late than never, hopefully fixed with [46d4ee0](https://github.com/adlnet/lrs-conformance-test-suite/commit/46d4ee02d75fdea099343a442c965bee9d608d3f) > > Thanks Milt! Thanks Trey! We'll give it a try.
@vbhayden Looks like the issue I described is indeed fixed, however there are still some issues with making an LRS backwards compatible. Need to run them all down but for...
Agreed. The way I read 2.8 it doesn't explicitly disallow adding versions to the list, just specifies what 1.0.3 expects to find there, and one would expect that as novel...
> Just updated the 1.0.3 and 2.0.0 about tests to hopefully be cross-compatible with each other etc. Thanks, I'll run my tests again!
```shell ➜ lrs-conformance-test-suite git:(master) ✗ node bin/console_runner.js \ -e http://localhost:8080/xapi \ -bz --xapiVersion 1.0.3 error: unknown option `--xapiVersion' ``` Did the option change since yesterday? These same args worked to...
> ```shell > ➜ lrs-conformance-test-suite git:(master) ✗ node bin/console_runner.js \ > -e http://localhost:8080/xapi \ > -bz --xapiVersion 1.0.3 > > error: unknown option `--xapiVersion' > ``` > > Did the...