Miloslav Hůla

Results 108 comments of Miloslav Hůla

Add warning about wrong regex form in Assert::match() in tester output

Related to #350

Extract storeAssertDiff from Dumper::dumpException

I'll check it during next week.

Extract storeAssertDiff from Dumper::dumpException

Btw what the purpose is?

Extract storeAssertDiff from Dumper::dumpException

Thanks for rebase! Your `storeAssertDiff()` does two things. Translates exception into message and creates dump files (arg reference is not nice public API). Do you need both? I know mango...

Another failure in FileMock

@JanTvrdik I thought it has been solved but it's still failing on 3v4al.org. Did you report PHP bug? I can't find any open or solved.

Another failure in FileMock

But in doc of `fopen()` > `a` - Open for writing only; place the file pointer at the end of the file. If the file does not exist, attempt to...

Another failure in FileMock

Will see https://bugs.php.net/bug.php?id=76995

Another failure in FileMock

As I expected, it is a [problem of lower layer](https://bugs.php.net/bug.php?id=76995#1539187632). So, documentation issue. Is a good idea to emit notice by `FileMock::stream_seek()` in `a+` mode? IMHO yes, it may notice...

Another failure in FileMock

Still buggy in PHP 8.0

Show the first difference when comparing large arrays

I like the second option with path.