giticket icon indicating copy to clipboard operation
giticket copied to clipboard

Update is only bailed if ticket is in first line

Open t4n0 opened this issue 2 years ago • 1 comments

Hi,

first of all: Thank you for your work here. Love it.

Unfortunately the bail does not work for our use case. We add the ticket not in the first line but are required to add it to the body of the commit message. In that case the early return you provided does not work and the ticket is added twice (e.g. when amending an exisiting commit).

I forked your repo and changed it to our needs: https://github.com/t4n0/giticket/commit/8f4ff1987d7de93dd58171373f8e5153b45e9fd7

Is this something you would consider fixing upstream, too? If so let me know.

Thanks

t4n0 avatar Jul 15 '22 14:07 t4n0

Yes, please consider opening a pull request with your changes. Happy to review it and merge it if applicable, when i get sometime this week.

milind-shakya-sp avatar Jul 18 '22 14:07 milind-shakya-sp