python-j1939 icon indicating copy to clipboard operation
python-j1939 copied to clipboard
verified publisher icon milhead2

enables operation with 11-bit CAN messages

Open DaveP987 opened this issue 3 years ago • 2 comments

fixes #18

Introduces a new strict parameter to Bus that specifies whether to operate strictly on J1939 messages or J1939 and 11-bit CAN messages. strict=True by default to maintain the current behavior.

Handling of PDU vs non-PDU messages is broken out into separate methods.

So far, this seems to work fine for me as a simple drop-in replacement for can.interface.Bus using existing 11-bit messaging.

DaveP987 avatar Sep 02 '22 14:09 DaveP987

@milhead2, I'm thinking of a slight change of course to this PR. I'm coming up against some more ways that I need to be involved in message activity that would need to be implemented as a Bus sub-class. With that, I think my plan will simply be to do some simple refactoring of Bus so that my sub-class has access to hooks that it needs without altering the current behavior.

DaveP987 avatar Nov 11 '22 14:11 DaveP987

Hi Dave, I'm doing some repo maintenaince for pythin-can and you have an old PR. Are you still interested in me merging it? Let me know and I'll take a harder look at it.

Miller

milhead2 avatar Apr 28 '23 19:04 milhead2