python-j1939 icon indicating copy to clipboard operation
python-j1939 copied to clipboard

Published 20 hours ago • verified publisher icon milhead2

Official version and release package?

Open johanbrus opened this issue 4 years ago • 4 comments

I am pretty new to this library, forgive me if I'm asking too much, but I was wondering:

  1. Is there any way this package could get an upgrade to make it an official pypi release for example "python-j1939"?
  2. Is there any way to pull a version number out of this package (e.g. with a .version command or similar?
  3. Are there any plans to set up some more extensive documentation for this project (e.g. using the readthedocs.io website)? I just feel this library has more potential, but myself am not too familiar with programming yet.

I had a look at another j1939 attempt https://github.com/benkfra/j1939 but this seemed to have come after the python-j1939 can and has not been maintained for about 2 years. Seems like the python-j1939 may be more worthwhile giving an upgrade to make it official.

johanbrus avatar Aug 20 '20 14:08 johanbrus

Hi John,

I took over management of this package when it was deleted from Brian Thorne's hardbyte/python-can as we used it at work as part of a regression test suite and a bunch of engineering tools. I don't really have plans or time to do anything more than chase a few defects (like your other issue). But I would encourage anyone that has time and motivation to contribute what they think it needs as long we we don't regress the interface. I probably have some better examples around as well...
I hope that helps! Mil

milhead2 avatar Aug 20 '20 15:08 milhead2

Thanks Mil, I just wondered if maybe others could help so just wanted to put it out there. It has a low star rating but maybe in time someone will be able to pick it up. Thanks anyway for preserving this package!

johanbrus avatar Aug 20 '20 15:08 johanbrus

Sorry tor the quick response! I've taken PR's from several folks that have found fixes. If you have fixes you want to test send me a PR and If it does not break my scripts I have no problem letting it in.

milhead2 avatar Mar 25 '22 18:03 milhead2

Hi Mil, at this time we have switched over to another package for our J1939 needs (https://github.com/juergenH87/python-can-j1939) so I don't need any changes anymore. Feel free to do with this issue whatever you see fit. Thank you for the help.

johanbrus avatar May 11 '22 15:05 johanbrus