Marcus Ilgner

Results 132 comments of Marcus Ilgner

Phew, hard to say. From the top of my head I can't think of anything. Will check it out...

Ok, this should be fixable. I'll need a TC 9 installation to test it, will take a shot at it over the weekend...

I did some investigation over the weekend and believe I have successfully fixed the problem. Unfortunately, the computer I used to use for TeamCity testing doesn't seem powerful enough to...

Once I'm done I'll upload a build artifact as a zip to Github so you can easily download it and drop it into the plugins folder of your TC data...

Looks like there was heavy discussion on #2 but in the end no fix could be found? I just found Mobvious but if it still breaks `send_file`, I'd be unable...

Upstream `joi` (not `@hapi/joi` anymore) is at v17 already. The published version uses 15.1.1 and I could only get it to run after downgrading my dependency to 15.1.1, too.

Found the following `TODO` comment in `stream.rs` of the mssql module: ``` pub(crate) fn write_packet>(&mut self, ty: PacketType, payload: T) { // TODO: Support packet chunking for large packet sizes...

Simplified the code to not require `lazy_static`, added working tests and fixed a bug with scale>5 along the way. Let me know if you'd like to change anything.

I further improved the implementation by decoding `datetime2` as `chrono::NaiveDateTime` instead and adding support for `datetimeoffset`, too, which is treated as `chrono::DateTime` with proper offset information. Suggestions for additional improvement...

> @milgner It appears that the only flaw here is a lack of a `cargo fmt` run before all checks would pass; Can we try to get this merge-ready before...