milesial comments

Results 62 comments of


                                            milesial

Foreach gradient clipping

@wonjoolee95 CI passed, can you merge the XLA PR?

Foreach gradient clipping

Thanks, let's hope it goes smoothly @pytorchbot merge -f "coordinating merge with XLA, CI passed"

Foreach gradient clipping

Haha I can't force merge, @janeyx99 can you help?

Foreach gradient clipping

I think keeping `eac4e` is fine no? No need to switch to `8dca` right? @pytorchbot merge -g

Foreach gradient clipping

Nice, I guess the XLA side can re-revert, sorry for the commit mess haha. And thanks for the help, that was a fun force-push-to-prod Friday

Update Documentation

@tmbdev Hi, any news on this? Would be good if docs were up to date

NVTX domains, categories, colors

Not sure why the windows build fails because of undeclared symbol, does anybody know if the NVTX header is included differently in windows vs linux?

NVTX domains, categories, colors

@malfet Do you have some guidance about the windows build fail?

NVTX domains, categories, colors

@malfet gentle ping

NVTX domains, categories, colors

Ah yes NVTX1 on windows instead of NVTX2 must explain it, thanks! Seems like the best way to handle it is to wait for NVTX3 to get merged in https://github.com/pytorch/pytorch/pull/90689...