Milan Klöwer

Results 204 comments of Milan Klöwer

I get the same error message when using the `@unpack` macro from Parameters.jl ```julia julia> struct AB A B end julia> @floop for i in 1:2 @unpack A = AB...

So what would people think about ```julia isprobvec(p::AbstractVector{ x ≥ zero(x), p) && isapprox(sum(p), one(eltype(p))) function entropy(p::AbstractVector{ entropy([0.5,0.5],2) # as before 1.0 julia> entropy([1,1],2) #  throws an error ERROR: ArgumentError:...

I don't know whether the -0 here ```julia julia> entropy([0,1]) -0.0 ``` is usually just ignored, but I guess it would be more proper if did instead of `return -sum(xlogx,...

On the argument constraint `::AbstractVector{ entropy([1,1+im]) # complex probabilities 0.43882457311747564 - 1.131971753677421im julia> entropy(rand(2,2)) # matrix input 1.0956946888140768 ``` Not even in quantum mechanics are complex probabilities a thing afaik,...

> Joint entropy, mutual information and so on should better be defined seperately. I agree, the entropy calculation her easily returns not what people would expect if we allowed matrices,...

No, the argument is correctly passed on (this happens through `;kwargs...` which just takes all keyword argument and so `kwargs` can be passed on to functions inside functions). ```julia julia>...

Just changed the title of this issue because this is really what this is about: Counting information across array bounds is like periodic boundary conditions, if you mask the last...

This issues will be addressed in #30

I've added more tests in #30 and merged the PR as all of them pass. I'd still love to see the impact if you could share your results @aaronspring at...

_Originally posted by @aaronspring in https://github.com/milankl/BitInformation.jl/issues/30#issuecomment-1080539133_ @milankl I find differences whether using `mask` or not, specially the first bits and within 99-100% information: dim: 4 `time` from https://gist.github.com/aaronspring/5de0bc6be5a8d547f3503ff8b1aef8c6 dim: 1...