Milan Klöwer
Milan Klöwer
> Can this even be done, given that CodecZstd isn't even a dependency or weal dep? riiiiiight, forgot that. Any reason then not to merge this?
Just added BitInformation to the Project.toml, due to dependency on `StatsBase` and `Distributions` this also adds ``` Updating `~/git/Oceananigans.jl/Project.toml` [de688a37] + BitInformation v0.6.1 Updating `~/git/Oceananigans.jl/Manifest.toml` [66dad0bd] + AliasTables v1.1.2 [de688a37]...
After installing your branch here and my branch from https://github.com/JuliaIO/JLD2.jl/pull/560, I get this ```julia julia> using JLD2, CodecZstd, HDF5, H5Zzstd │ Package H5Zzstd not found, but a package named H5Zzstd...
> IIUC the regular `ZstdDecompressor` should work with both formats. I can test this @nhz2. EDIT: Yes, works as before so doesn't matter whether setting `ZstdDecompressor` or `ZstdFrameDecompressor` in JLD2,...
@mkitti this works: ```julia julia> using JLD2, CodecZstd julia> A = zeros(1000,1000); julia> A[1] = rand() 0.1653492903631878 julia> save("test_with_zstd_compression.jld2", "A", A, compress=ZstdFrameCompressor()) julia> A == load("test_with_zstd_compression.jld2", "A") true ``` while...
I don't have any opinion on the streaming vs non-streaming API... I just would like to get his here merged so that we can merge https://github.com/JuliaIO/JLD2.jl/pull/560 and have Zstd compression...
@JeffreySarnoff do you have an idea? There's something wrong with the rounding for subnormals I assume... https://github.com/milankl/Float8s.jl/blob/9345556ac3d11f61bef2c70f49947113b8949066/src/float8.jl#L164-L193
Yeah great, I always forget how small 8bit actually is. Will check how much faster that is!
Yep, a lookup table made it about 2x faster. I've added an `@inbounds` which gave another 2x speed-up. ```julia Base.Float32(x::Float8) = @inbounds Float8toFloat32[reinterpret(UInt8,x) + 0x01] ```
Amazing Jeffrey, I'll implement that in the next days, thanks so much!