livereactload icon indicating copy to clipboard operation
livereactload copied to clipboard

Published 20 hours ago • verified publisher icon milankinen

Support Web Workers

Open gmaclennan opened this issue 8 years ago • 2 comments

When I use livereactload with a React app (0.14.7) with mapbox-gl-js I get errors with Web Workers (which mapbox-gl-js uses webworkify to create). I don't really know enough about how livereactload works to debug further. It seems to be related to module detection and browserify wrapping in the web worker? Without livereactload everything works fine. I am using babelify, seeing this in both babel v5 & v6, and both using ES2015 and CommonJS module syntax.

gmaclennan avatar Feb 18 '16 19:02 gmaclennan

Thanks! I'll check this. Never tried to run LiveReactload with web workers so potential bug here.

milankinen avatar Feb 19 '16 11:02 milankinen

Here is my code so that you can see the problem with live loading mapbox-gl-js, on the rewrite branch: https://github.com/digidem/mapfilter/tree/rewrite

./node_modules/.bin/budo ./src/index.js:bundle.js -- -p livereactload should give the error.

gmaclennan avatar Mar 09 '16 01:03 gmaclennan