microphone.js icon indicating copy to clipboard operation
microphone.js copied to clipboard

Pull Request coming up

Open pdeschen opened this issue 13 years ago • 5 comments

@milani I've just complete an overhaul of your library to become a jquery plugin along with adding support for event handling, including a new one for VAD and some code clean up within the AS.

If you're interested in receiving such pull request, let me know and I'll send over. Check out my changes.

pdeschen avatar Oct 22 '12 03:10 pdeschen

Hey it's nice. Would you manage the repo to have both pure JS library and jquery plugin at the same time? Then I'll be happy to receive the pull request:).

milani avatar Oct 22 '12 05:10 milani

Ill have a look at how to do so. What could be possible is to have the plugin as a wrapper around the pure one. I'll keep you posted how it goes.

pdeschen avatar Oct 25 '12 02:10 pdeschen

Did it ever hapen ?

darkyen avatar May 06 '13 13:05 darkyen

@darkyen nope. never had time to uncouple. Feel free to fork my repo, modify and issue a PR.

I might have some spare time in the upcoming week to tackle this. I'll let you guys know if I do.

pdeschen avatar May 06 '13 14:05 pdeschen

:-) i ended up using Wami & node.js upgrading to webAudio / MediaStream & node.js solution :-) but sure i will give it a try

darkyen avatar May 07 '13 07:05 darkyen