jalali icon indicating copy to clipboard operation
jalali copied to clipboard

Laravel 5

Open kamioon opened this issue 11 years ago • 10 comments

Hi, Any plan for L5 ?

kamioon avatar Mar 11 '15 16:03 kamioon

I didn't test it for L5 yet but i think it will work.

miladr avatar Mar 11 '15 20:03 miladr

I tested, it works. But you should not add Service provider ("Miladr\Jalali\JalaliServiceProvider" ) in config/app.php it will works with only namespace and adding:

use Miladr\Jalali\jDate;

where that you want Jalali date.

if add "Miladr\Jalali\JalaliServiceProvider" to providers array we have error.

kamioon avatar Mar 12 '15 05:03 kamioon

You have error because "provides" function in service provider. Please remove "provides" function from service provider and inform me if it's working.

miladr avatar Mar 12 '15 08:03 miladr

L5 packaging has changed. There are several posts online about bridging L4->L5 and some workarounds. https://medium.com/@morrislaptop/bridging-laravel-4-packages-to-laravel-5-2081f19643c6

This specific issue wasn't fixed by removing "provides". Instead I remarked JalaliServiceProvider.php line 21: // $this->package('miladr/jalali');

It seems working.. still needs to be tested and to find out if it misses functionality

sinaghazi avatar Mar 28 '15 02:03 sinaghazi

@miladr What should I do? can you help me?

ebrahimradi avatar Jun 03 '15 07:06 ebrahimradi

من هم توی لاراول 5 مشکل داشتم باهاش که کاری که sinaghjazi کردن رو هم منم انجام دادم و مشکل حل شد. اما اگر شما مشکل رو برطرف کنید و یه ریلیز بدید بهتره ممنون

saeedsajadi avatar Sep 05 '15 12:09 saeedsajadi

Take a look at this : https://packagist.org/packages/p3ym4n/jdate

p3ym4n avatar Apr 03 '17 19:04 p3ym4n

Unfortunately, i don't have enough time to maintain this package. consider using : https://github.com/opilo/farsi It's fully tested.

miladr avatar Apr 03 '17 21:04 miladr

@p3ym4n Great work. I think you need to add tests to your package.

miladr avatar Apr 03 '17 21:04 miladr

@miladr It have tests 👍

p3ym4n avatar Oct 20 '17 20:10 p3ym4n