climate-cooperation-competition icon indicating copy to clipboard operation
climate-cooperation-competition copied to clipboard

Published 20 hours ago • verified publisher icon mila-iqia

Possible bugs on trading and tariff actions

Open ponseko opened this issue 6 months ago • 0 comments

Looks like in the current calc_normalized_import_bids, the import bids remain zero if the desired_exports < max_exports. This value is then used to get the gross import, so this seems pretty damaging to trading:

https://github.com/mila-iqia/climate-cooperation-competition/blob/f743956803b37412ed11cf8d864f236e3487a1f1/rice.py#L1249-L1275

Furthermore, the import_tariff actions seem to be delayed by a timestep. Both calc_trade_sanctions and calc_welfloss_multiplier, get the action from the prev_state. Is this intentional?

https://github.com/mila-iqia/climate-cooperation-competition/blob/f743956803b37412ed11cf8d864f236e3487a1f1/rice.py#L767-L768

https://github.com/mila-iqia/climate-cooperation-competition/blob/f743956803b37412ed11cf8d864f236e3487a1f1/rice.py#L797-L815

ponseko avatar Aug 16 '24 15:08 ponseko