blocks icon indicating copy to clipboard operation
blocks copied to clipboard

Blocks and Fuel define the version in two different ways

Open rizar opened this issue 10 years ago • 2 comments

blocks/__init__.py:

__version__ = '0.0.1'

fuel/__init__.py:

try:
    DIST = get_distribution('fuel')
    DIST_LOC = os.path.normcase(DIST.location)
    HERE = os.path.normcase(__file__)
    if not HERE.startswith(os.path.join(DIST_LOC, 'fuel')):
        raise DistributionNotFound
except DistributionNotFound:
    __version__ = 'not installed'
else:
    __version__ = DIST.version

I prefer Blocks way just because it is simpler. @vdumoulin , would you the respective change?

rizar avatar Oct 07 '15 20:10 rizar

Is this still needed @rizar?

dwf avatar Nov 12 '15 20:11 dwf

Yes, I will improve Blocks versioning in the same way as I did it in Fuel.

On 12 November 2015 at 15:50, David Warde-Farley [email protected] wrote:

Is this still needed @rizar https://github.com/rizar?

— Reply to this email directly or view it on GitHub https://github.com/mila-udem/blocks/issues/863#issuecomment-156230038.

rizar avatar Nov 12 '15 21:11 rizar