blocks icon indicating copy to clipboard operation
blocks copied to clipboard

added printing status and tests for it

Open mnoukhov opened this issue 7 years ago • 3 comments

Printing extension had default print_status=True without the ability to change it, I'm just adding it as a an argument.

Also added tests to a new test_printing.py, I found there was a printing test in test_progressbar but that felt more like a integration test than a unit test for something so simple as the print_status argument.

mnoukhov avatar Nov 29 '16 19:11 mnoukhov

Sorry for the late reply and thanks for the PR! I am a bit hesitant to merge it though. There is so many ways in which Printing could be customized, and it would never fit everybody's needs. This is why we have been keeping it primitive as it is so far.

rizar avatar Jan 02 '17 01:01 rizar

That makes sense, but the code already has just an unused variable print_status that is just never set. This change makes it usable and adds the ability to make normal runs (that don't need the status, which I imagine would be the majority) much cleaner.

mnoukhov avatar Jan 03 '17 20:01 mnoukhov

I think most people prefer to print status, because without printing it one doesn't even know how many iterations of training have been done.

rizar avatar Jan 09 '17 12:01 rizar