gluish icon indicating copy to clipboard operation
gluish copied to clipboard

Published 20 hours ago • verified publisher icon miku

0.2 ideas / cleanup

Open miku opened this issue 10 years ago • 3 comments

gluish 0.1.X contains both luigi-related and non-luigi-related code. For 0.2 only luigi-related code should stay in the package:

Keep:

  • task
  • format (TSV)
  • intervals
  • database helpers (seems generic enough)

Cleanup:

  • parameters (keep ClosestDateParameter)
  • utils (keep shellout)

Remove:

  • benchmark (timing decorators are simple)
  • colors
  • common
  • configuration
  • esindex (it's in luigi.contrib)
  • oai
  • path

miku avatar Mar 17 '15 10:03 miku

Would you mind merging some of it into the official luigi repo instead? I can go through the code and see what I think would make sense

erikbern avatar Mar 17 '15 11:03 erikbern

@erikbern, gluish started as glue for another project of ours, so that's why there's so much non-luigi-related code. But if we could move the essentials into luigi, I'd be happy.

I could prepare an essential branch and pre-filter the code, so you can go through it faster.

miku avatar Mar 17 '15 11:03 miku

I think at least TSVFormat would be useful. Also the elastic search stuff (not sure how much it overlaps with what's already in there)

erikbern avatar Mar 17 '15 12:03 erikbern