ikonate icon indicating copy to clipboard operation
ikonate copied to clipboard

Added support for both 'href' and the deprecated value 'xlink:href'

Open bramdoppen opened this issue 5 years ago • 2 comments

Added support for both 'href' attribute since 'xlink:href' is deprecated since SVG 2 (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href) according to W3C guidelines: "For backwards compatibility, elements with an ‘href’ attribute also recognize an ‘href’ attribute in the XLink namespace"(https://svgwg.org/svg2-draft/linking.html#XLinkRefAttrs).

bramdoppen avatar Oct 20 '18 11:10 bramdoppen

'xlink:href' is deprecated since SVG 2 indeed, however SVG 2 still doesn't have a Recommendation status and unfortunately, it doesn't look like it will get a one in the near future. For now, the most up-to-date version of SVG is still SVG 1.1 2nd Edition which is why it is used here

mikolajdobrucki avatar Feb 17 '19 18:02 mikolajdobrucki

That makes sense, adding them both seems to be the solution (for now..) according to W3C guidelines.

bramdoppen avatar Feb 21 '19 07:02 bramdoppen