id3-go icon indicating copy to clipboard operation
id3-go copied to clipboard

Remove trailing nulls from id3v1 strings in ParseTag()

Open viking opened this issue 10 years ago • 5 comments

viking avatar May 21 '14 21:05 viking

There's a strings package implementation of the null removal you might want to look at here.

Also is there a reason you used an anonymous struct instead of v1.Tag?

mikkyang avatar Jul 11 '14 00:07 mikkyang

I didn't know about strings.TrimRight, thanks. Also I'm not sure why I used an anonymous struct in the tests. Fixed both of those.

viking avatar Aug 15 '14 20:08 viking

I have fixed the issue that was causing Travis build to fail.

viking avatar Oct 22 '14 20:10 viking

The current error is caused because of Travis not being able to build Go itself from the tip branch. All other versions pass.

viking avatar Oct 22 '14 20:10 viking

we have the same problem with trailing nulls in v2.TextFrame

frodeaa avatar Mar 29 '15 21:03 frodeaa