pdb-controller icon indicating copy to clipboard operation
pdb-controller copied to clipboard

Update docker image :latest?

Open nicholasklem opened this issue 4 years ago • 3 comments

I noticed the docker image tagged :latest was not the latest on docker hub: https://hub.docker.com/r/mikkeloscar/pdb-controller/tags

Is 1 the current recommended docker image?

I made a Dockerfile to make images whenever master is updated:

FROM golang:alpine as builder
RUN apk add --update make git

# bust the cache when master is updated:
ADD https://api.github.com/repos/mikkeloscar/pdb-controller/git/refs/heads/master /version.json

RUN git clone https://github.com/mikkeloscar/pdb-controller.git /pdb-controller

WORKDIR /pdb-controller
ENV GO111MODULE=on
RUN make

FROM alpine
COPY --from=builder /version.json /pdb-controller/build/pdb-controller /
CMD ["/pdb-controller"]

Let me know when I can stop doing this and just pull :latest, :stable or something!

nicholasklem avatar Sep 12 '20 08:09 nicholasklem

I have added docker push to #26 so when this is merged it will at least keep updating :latest.

mikkeloscar avatar Sep 14 '20 06:09 mikkeloscar

How can I help you with the docker image?

vkobets avatar Jan 04 '23 13:01 vkobets

@vkobets with #49 the :latest image should not be available: mikkeloscar/pdb-controller:latest

If you want to have it e.g. based on tag you're welcome to contribute github action that can tag the image correctly.

mikkeloscar avatar Jan 04 '23 15:01 mikkeloscar