Miki

Results 152 comments of Miki

Please, have a look to the following findings described by #638 and #636: SNo | Rule | Severity | Message | Filename | Linenumber -- | -- | -- |...

> We can resolve this warning by renaming the variable names right ? Please check Probably yes. But can we agree together that these warnings are false positives? The problem...

Actually, we think that new findings `allocator` in `BitStreamReader.h` and `add` in `BitStreamWriter.cpp` are false positives as well.

I think this is expected behavior. The warning about `PackedArray` is not there because you actually pack the instantiated structure ``` struct PackedArrayString { varsize size; packed PackedArrayString data[size]; };...

If I got you correctly, I think your expectation is to have warning for each usage of instantiation not only for created instantiation. In another words, zserio currently fires warning...

OK, I see. We will discuss it internally. Thanks a lot for sharing this idea.

Thanks a lot for a comprehensive description of the problem. We will investigate it and come back to you.

Yes, `constexpr` will be better. Thanks to pointing this out!

We will have to check all consts in the generated code and in the C++ runtime library because of that. It would be good to have constexpr wherever it is...

Regarding functional safety features, consider to investigate the possibility of usage of static analysis tool at GitHub which can check Autosar C++ standard. More info is available here: https://github.blog/2022-06-20-adding-support-for-coding-standards-autosar-c-and-cert-c/.