mikiher
mikiher
ok, suppose the original audio file had metadata tags a=1, b=2, and c=3, and abs has tags b=4, c=5, e=6. then after embedding: - in "merge" the audio file has...
In my second commit, I implemented "merge"
Another thing I noted: tone does not explicitly write `track` (so if it existed, it remains the same, and if it did not exist, it is not populated). Should we...
> The trickier case would be if a is a meta tag Abs uses but it is empty in Abs. > For example, if the book does not have a...
OK, I think the code is ready for review now (and thanks for implementing track embedding). I haven't cleaned up Tone from the code yet. I'll do that once we've...
I also added some unit tests for the new functions in ffmpegHelpers.
Yes, third party, and I wasn't sure if the iOS and Android clients used that API endpoint. I try to be extra-cautious about breaking API - perhaps it's OK in...
Release v2.17.0 should have fixed a couple of OOM issue related to manual and automatic Podcast episode checks and downloads. I'd be very interested to know if you're still seeing...
Yeah, for some time I've been wanting to implement some match confidence score that estimates how likely it is that a match result is the right one. It doesn't seem...
> I think match confidence is a good idea. > > It would be easier to write the match confidence algorithm to work for any provider including custom providers if...