nerf-navigation icon indicating copy to clipboard operation
nerf-navigation copied to clipboard

Unused variable: `point_vels`

Open stalhabukhari opened this issue 2 years ago • 1 comments

Hello,

The point_vels variable is not used in loss computation:

https://github.com/mikh3x4/nerf-navigation/blob/7fd14ff6640602e49e92e2a54d40ba0e519debae/nav/quad_plot.py#L232

I am facing issues in the initial path planning and I believe this is relevant.

stalhabukhari avatar Nov 28 '22 18:11 stalhabukhari

This line computes the velocity of each individual point making up the robot point cloud.

You are correct that this is odd - In my memory I thought this is used in the next line instead of the velocity of the robot origin (vel), assuming correct numpy broadcasting, but it's not. Instead the velocity of the robot origin is used. I do think it is a good approximation when the robot isn't turning fast compared to its linear motion, but including the rotation is technically correct

mikh3x4 avatar Dec 08 '22 12:12 mikh3x4