sigpy icon indicating copy to clipboard operation
sigpy copied to clipboard

Deprecation warning with np.float, np.bool, np.complex

Open ad12 opened this issue 3 years ago • 5 comments

Describe the bug Starting around v1.20, numpy has deprecated generic data types (np.float, np.bool, np.complex) in favor of standard python types (float, bool, complex). This is causing a flurry of deprecation warnings in sigpy, where default types may be any of the generic numpy dtypes.

Recommendation Set explicit dtypes with explicit precision (e.g. np.float64 instead of np.float)

ad12 avatar Feb 06 '22 20:02 ad12

In progress #113

sidward avatar Jun 01 '22 18:06 sidward

I saw that this issue was fixed in a commit on Apr 6, but unfortunately the last tagged version that is used to build the conda-forge package is from Apr 3.

When do you plan to release a version that includes the fix?

I am asking, since I am wondering if I should change the conda-forge recipe (req. numpy <=1.19).

gschramm avatar Jun 27 '23 18:06 gschramm

In progress #113

any updates concerning a new release that includes that PR?

gschramm avatar Jul 27 '23 17:07 gschramm

I suffered from the same problem, and managed to work around it by installing numpy=1.19.5 in the conda environment.

berkinbilgic avatar Jan 18 '24 05:01 berkinbilgic