sigpy.mri.poisson hangs when seed & calib arguments are passed

[ad12]

Describe the bug sigpy.mri.poisson hangs when both the seed and calib arguments are passed in.

To Reproduce See this colab below https://colab.research.google.com/drive/1k0w6KjkPHx8U8K8dXmaFVi9hO1Cg1Z1e?usp=sharing

Expected behavior Passing both these arguments together should not cause the program to hang

[sidward]

Thanks for the report. This is really strange -- I am not sure why modifying the seed would cause anything to hang, but I see it on my side as well.

[sidward]

@ad12 I just pushed a commit (815e17d2df1da967616d0ae8d42da36ff923a8a8) that hopefully fixes the problem for you -- It does on my end. Please re-open if this is not the case.

[sidward]

@ad12 If you are able, can you submit a PR with your reproducing code as a test? I would like to add it in-case numba/jit has an issue with the current fix later on.

[sidward]

Reopening -- This is not fixed for all cases. We think this is an issue with Numba.

[lukasfolle]

I encountered this problem too. For a quick fix was changing https://github.com/mikgroup/sigpy/blob/master/sigpy/mri/samp.py#L157 to just @jit.

[sidward]

Do you have an estimate of the performance penalty, if any?

[lukasfolle]

I havent benchmarked it. Probably depends also on the input size.

[sidward]

Hi, sorry for the delay in getting to this -- would you be able to benchmark it at all? No worries if not.

[lukasfolle]

No worries. Unfortunately, I won't have time to benchmark it.

---

Von: Siddharth Srinivasan @.***> Gesendet: Mittwoch, 16. Februar 2022 21:27:20 An: mikgroup/sigpy Cc: Folle, Lukas (CS5); Comment Betreff: Re: [mikgroup/sigpy] sigpy.mri.poisson hangs when seed & calib arguments are passed (Issue #102)

Hi, sorry for the delay in getting to this -- would you be able to benchmark it at all? No worries if not.

— Reply to this email directly, view it on GitHubhttps://github.com/mikgroup/sigpy/issues/102#issuecomment-1042209367, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGKDMUI4KRZRZRNKCNV5M3DU3QCCRANCNFSM5JPHJYOA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.Message ID: @.***>