gallery-dl icon indicating copy to clipboard operation
gallery-dl copied to clipboard

[BUG] Deviantart deviations search download the wrong results

Open afterdelight opened this issue 2 years ago • 3 comments

i tried to download a deviant user named fu-reiji and his account was deactivated but his work is still search able on https://www.deviantart.com/search/deviations?q=fu-reiji

results:

F:\downloader\deviant art>gallery-dl https://www.deviantart.com/search/deviations?q=fu-reiji
* .\Cryptid-Creations\510890840_Day 802# Garfeild's First Lasagna.png
* .\sandara\535480554_Mad Max - War Beasts.jpg
* .\yuumei\599726678_Replacement for the Stars.jpg
* .\Charlie-Bowater\670768474_Starfall.jpg
* .\TsaoShin\2B\454351411_Thank You - 4K on Facebook!.png

wrong users downloaded

test single link:

F:\downloader\deviant art>gallery-dl https://www.deviantart.com/fu-reiji/art/Part-timer-Homura-617581110
* .\Fu-reiji\617581110_Part timer Homura.jpg

the right user downloaded

afterdelight avatar Sep 21 '22 20:09 afterdelight

Just download normally, before it's all gone. The search is useless, anyway; the search is doing as designed cuz the fu-reiji query means "search everywhere for an instance of fu-reiji", which, CWCID, is doing the same as Google normally does.

rautamiekka avatar Sep 21 '22 21:09 rautamiekka

I can't. The account was deactivated https://www.deviantart.com/fu-reiji

afterdelight avatar Sep 21 '22 21:09 afterdelight

You can, I just tried and have downloaded so many deac/banned DA accs I can't count that far.

rautamiekka avatar Sep 21 '22 21:09 rautamiekka

Oh you were right, i can download the deactivated acc. But i still want to request fix for something general like https://www.deviantart.com/search/deviations?q=nude+filter which still downloaded the wrong users

afterdelight avatar Sep 21 '22 22:09 afterdelight

The Deviantart OAuth API, which is what gallery-dl uses, does not support fetching search results. The only thing that slightly resembles a search is the /browse/popular endpoint and its q parameter, so that's what gets internally used to emulate a search.

So fixing this and some other issues depends on gallery-dl updating its dA code base to using the Eclipse API, but how, when, and if this is going to get done is something I couldn't tell you. Maybe never or only for v2.0, since this would probably cause a lot of backwards incompatible changes.

There is a branch that hasn't seen any updates in more than 3 years, by the way: https://github.com/mikf/gallery-dl/tree/deviantart-rewrite

mikf avatar Sep 23 '22 17:09 mikf

well, now thats too bad

afterdelight avatar Sep 27 '22 20:09 afterdelight

The Deviantart OAuth API, which is what gallery-dl uses, does not support fetching search results. The only thing that slightly resembles a search is the /browse/popular endpoint and its q parameter, so that's what gets internally used to emulate a search.

So fixing this and some other issues depends on gallery-dl updating its dA code base to using the Eclipse API, but how, when, and if this is going to get done is something I couldn't tell you. Maybe never or only for v2.0, since this would probably cause a lot of backwards incompatible changes.

There is a branch that hasn't seen any updates in more than 3 years, by the way: https://github.com/mikf/gallery-dl/tree/deviantart-rewrite

So you say that there is literally no way to fetch images, if I want to combine two tags for example?

SavvaI avatar Feb 05 '23 18:02 SavvaI