cds-dbm icon indicating copy to clipboard operation
cds-dbm copied to clipboard

Where to implement reserved keyword check? cds-dbm or cds-pg

Open gregorwolf opened this issue 2 years ago • 3 comments

In #179 this issue was identified:

But 'user' turns out to be a reserved keyword in Postgresql.
https://www.postgresql.org/docs/current/sql-keywords-appendix.html Might be an idea to scan for those and give a warning ?

the question is where do we implement this? in cds-dbm or cds-pg.

gregorwolf avatar Apr 07 '22 13:04 gregorwolf

What do you think @vobu?

gregorwolf avatar Apr 07 '22 13:04 gregorwolf

I'd vote for both:

  • in cds-pg when serving any .cds that contains user as an entity
  • in cds-dbm at deploy-time

vobu avatar Apr 08 '22 07:04 vobu

Great. It could also be nice to include a warning on the combined length of a table / view exceeding the hard limit of 63 characters. See #180

sedacrivity avatar Apr 08 '22 09:04 sedacrivity