nonoCAPTCHA icon indicating copy to clipboard operation
nonoCAPTCHA copied to clipboard

Can't close chrome

Open AlexandrMoruk opened this issue 6 years ago • 3 comments

Hello! I use your library to collect images from captcha, but the browser does not close. Function cleanup() is called, writes a log 'Browser closed', but browser.close() doesn't work.

AlexandrMoruk avatar Nov 29 '18 08:11 AlexandrMoruk

I was mistake in the description, the browser is chromium

AlexandrMoruk avatar Nov 29 '18 10:11 AlexandrMoruk

Hello, I will look into this and get it sorted out. What operating system did this occur on?

mikeyy avatar Dec 06 '18 22:12 mikeyy

Hello? sorry for the delay, Ubuntu 18.04, I am not sure but function Browser.create in launcher.py passes argument self.killChrome to the fourth, and must a six. Sorry for my English)

@staticmethod
   async def create(connection: Connection, contextIds: List[str],
                    ignoreHTTPSErrors: bool, appMode: bool,
                    process: Optional[Popen] = None,
                    closeCallback: Callable[[], Awaitable[None]] = None,
                    **kwargs: Any) -> 'Browser':
       """Create browser object."""
       browser = Browser(connection, contextIds, ignoreHTTPSErrors, appMode,
                         process, closeCallback)
       await connection.send('Target.setDiscoverTargets', {'discover': True})
       return browser

AlexandrMoruk avatar Dec 11 '18 11:12 AlexandrMoruk