regexp-make-js

regexp-make-js copied to clipboard

Clean up some of the `var`s and loops.

1

There's zero reason in 2015 to use a loop, or "var" - this cleans some of them up. There's still a bunch left, but I figured I'd tackle just a...

ljharb

Interpolating RegExps with capturing groups changes group numbering of groups in the template.

8

`RegExp.make`${ /(foo)/ }(bar)`` has 1 group in the template, (bar). In the matched output, this group will be at an index 1 + numberOfGroupsIn(/(foo)/), in this case 2. Figure out...

mikesamuel

Ensure this works for `RegExp` subclasses

8

I don't see spec text yet, so it may not be a problem yet - but let's make sure that ```js class Foo extends RegExp {} ; Foo.make`${foo}` ``` returns...

ljharb

Update test text, since test now works on Canary too.

1

https://rawgit.com/mikesamuel/regexp-make-js/master/test/index.html now works in Chrome Canary 50 as well, so the failure text should mention this in addition to modern Firefoxen.

erights

How are backreferences adjusted?

7

When regex instances are interpolated in blocks, the comment mentions "_With back-references adjusted_". What does that mean? The tests don't really help me to understand this: ``` js RegExp.make `^(#+)([^#\r\n]*)${...

bergus

Status

2

Hey, where does this repo stand? How can we help progress this in the spec?

benjamingr

Avoid "Inlined without wrapping"

2

The [Expressions table](https://github.com/mikesamuel/regexp-make-js#expressions) does allow arbitrary values to be inlined "without inlining" in some contexts. I think that's a bad idea. This wording seems to suggest that the following things...

bergus

Disallow irregular patterns

8

The current regex grammar is quite [liberal](http://www.ecma-international.org/ecma-262/6.0/#sec-regular-expressions-patterns) about `SyntaxCharacter`s that appear in places where they are not allowed. For example, `/a{/` is just taken literally. This complicates parsing, and deciding...

bergus

Flags in tag

8

The problem of current conception in flags. Because of them, `RegExp.make` should return a function. What about simple solution: ``` js RegExp.make`${source}` RegExp.make('igm')`${source}` // -> RegExp.make`/${source}/` RegExp.make`/${source}/igm` ``` ? Like...

zloirock

If we can do `myMake = RegExp.make("")("g")("i")("")…` anyway, let it be useful at least :-) I wonder what TC39 will say to this pattern, though. There are no curried functions...

bergus